taubem
/
ChangeCalendar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

changed foreach to for loop - to get rid of try catch

main
Said Gedik 2023-05-25 13:52:22 +02:00
parent 6e34a72a8b
commit a4a153ec6b
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
backend/src/main/java/com/nttdata/calender/changes/Change.java
View File

@ -112,7 +112,8 @@ public class Change {
var entriesSize = api.getFormSize(qualifier, this.queryChange.getFormName());
System.out.println(entriesSize);
var changes = new ArrayList<ChangeItem>();
entries.forEach(entry -> {
for (var entry : entries) {
var change = new ChangeItem(entry.getEntryId());
change.setChangeNr(getValueStringByID(entry, "ChangeNr"));
change.setSupportGroup(getValueStringByID(entry, "SupportGroup"));
@ -140,23 +141,20 @@ public class Change {
.map(Object::toString)
.filter(peopleFullName::equals)
.isPresent());
try {
var currentState = getValue(entry, "State").getIntValue();
var inApproval = inApprovalList(api.getUser(), getValueStringByID(entry, "ChangeNr"));
var approve_reject = flagApproval(inApproval, currentState);
change.setFlagApprove(approve_reject);
change.setFlagReject(approve_reject);
var cancel = flagCancel(getValueStringByID(entry, "SupportGroupId"), currentState);
change.setFlagCancel(cancel);
var currentState = getValue(entry, "State").getIntValue();
var inApproval = inApprovalList(api.getUser(), getValueStringByID(entry, "ChangeNr"));
var cancel = flagCancel(getValueStringByID(entry, "SupportGroupId"), currentState);
var approve_reject = flagApproval(inApproval, currentState);
change.setFlagApprove(approve_reject);
change.setFlagReject(approve_reject);
change.setFlagCancel(cancel);
change.setFlagToApproval(flagToApproval(currentState));
change.setFlagToApproval(flagToApproval(currentState));
} catch (ARException e) {
e.printStackTrace();
}
changes.add(change);
});
}
api.freeImpersonatedUser();
return new ChangeResponse(entriesSize, changes);
@ -168,8 +166,9 @@ public class Change {
var approversOI = api.queryFieldsById("\'Ticketnumber\' = \"" + changeNr + "\"",
queryApprovalList.getFieldIds(), queryApprovalList.getFormName(), null, 0, 0);
var approvers = approversOI.isEmpty() ? null : approversOI.get(0).get(queryApprovalList.getFieldId("Approvers")).toString();
var approvers = approversOI.isEmpty() ? null
: approversOI.get(0).get(queryApprovalList.getFieldId("Approvers")).toString();
return approvers != null ? approvers.contains(user) : false;
}
@ -179,9 +178,11 @@ public class Change {
}
public boolean flagCancel(String supportGroupId, int status) throws ARException {
var queryRoles = new Query.QueryBuilder("CTM:SupportGroupFuncRoleLookUp").addFieldId("Role", 1000000014).build();
var role = api.queryFieldsById("\'Support Group ID\' = \"" + supportGroupId + "\"", queryRoles.getFieldIds(), queryRoles.getFormName(), null, 0, 0)
.get(0).get(queryRoles.getFieldId("Role")).toString();
var queryRoles = new Query.QueryBuilder("CTM:SupportGroupFuncRoleLookUp").addFieldId("Role", 1000000014)
.build();
var role = api.queryFieldsById("\'Support Group ID\' = \"" + supportGroupId + "\"",
queryRoles.getFieldIds(), queryRoles.getFormName(), null, 0, 0)
.get(0).get(queryRoles.getFieldId("Role")).toString();
boolean approvableStatus = status == 1;
boolean isChangeManager = role.equals("Change Manager");