From 2decd5358b0ca54fb35b7eab33a6ebcebea609a4 Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Wed, 23 Mar 2022 17:22:34 +0100 Subject: [PATCH 01/13] Login and VehicleList --- EMEA_PROD/slo/TP_Mobile_Login.tf | 26 ++++++++++++++++---------- EMEA_PROD/slo/TP_Mobile_VehicleList.tf | 24 ++++++++++++++---------- 2 files changed, 30 insertions(+), 20 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Login.tf b/EMEA_PROD/slo/TP_Mobile_Login.tf index 10d72a4..a900d6d 100644 --- a/EMEA_PROD/slo/TP_Mobile_Login.tf +++ b/EMEA_PROD/slo/TP_Mobile_Login.tf @@ -14,16 +14,22 @@ module TP_Mobile_Login { metric_expression = <<-EOT (100)- (builtin:service.keyRequest.errors.server.rate:filter( - and( - or( - in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"btc-user-composite-service - PROD~") - ) - ") - ) + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"btc-user-composite-service - PROD~") + ) + ,entityName.in( + ~"GET /api/v1/presentation/oauth/config~", + ~"GET /api/v1/presentation/profile-tab~", + ~"POST /api/v1/oauth/token/identifier~" + )") + ) ))):splitBy():sum:auto:sort(value(sum,descending)))" EOT diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf index 76215c0..6861812 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf @@ -14,16 +14,20 @@ module TP_Mobile_VehicleList { metric_expression = <<-EOT (100)- (builtin:service.keyRequest.errors.server.rate:filter( - and( - or( - in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"btc-vehicle-composite-service - PROD~") - ) - ") - ) + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"btc-vehicle-composite-service - PROD~") + ) + ,entityName.in( + ~"GET /api/v1/vehicles~" + )") + ) ))):splitBy():sum:auto:sort(value(sum,descending)))" EOT From 6f3eadcced50d9dca8b8ee4c31388c09c01a22c3 Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Thu, 24 Mar 2022 12:32:44 +0100 Subject: [PATCH 02/13] adjusted TP_Mobile_Login EMEA PROD --- EMEA_PROD/slo/TP_Mobile_Login.tf | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Login.tf b/EMEA_PROD/slo/TP_Mobile_Login.tf index a900d6d..6a737a1 100644 --- a/EMEA_PROD/slo/TP_Mobile_Login.tf +++ b/EMEA_PROD/slo/TP_Mobile_Login.tf @@ -21,8 +21,10 @@ module TP_Mobile_Login { entitySelector( "type(service_method), fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName.in - (~"btc-user-composite-service - PROD~") + type(~"SERVICE~"),entityName.in( + ~"btc-user-composite-service - PROD~", + ~"btc-connected-oauth-service - PROD~" + ) ) ,entityName.in( ~"GET /api/v1/presentation/oauth/config~", From d0d931d7b1a7a4f92c7923ffad058b1987f3e6aa Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Thu, 24 Mar 2022 14:13:23 +0100 Subject: [PATCH 03/13] adjusted TP_Mobile_Mapping --- EMEA_PROD/slo/TP_Mobile_Mapping.tf | 31 ++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Mapping.tf b/EMEA_PROD/slo/TP_Mobile_Mapping.tf index 8dbb4eb..fd1c86a 100644 --- a/EMEA_PROD/slo/TP_Mobile_Mapping.tf +++ b/EMEA_PROD/slo/TP_Mobile_Mapping.tf @@ -14,16 +14,27 @@ module TP_Mobile_Mapping { metric_expression = <<-EOT (100)- (builtin:service.keyRequest.errors.server.rate:filter( - and( - or( - in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"vehicle-mapping-composite-service - PROD~") - ) - ") - ) + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-user-composite-service - PROD~", + ~"vehicle-mapping-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v2/presentation/users/validate~", + ~"POST /api/v2/vehicles//primary~", + ~"POST /api/v2/vehicles//primary/map~", + ~"POST /api/v1/vehicles//validate-security-code~", + ~"POST /api/v1/vehicles//resend-security-code~", + ~"DELETE /api/v1/vehicles/~" + )") + ) ))):splitBy():sum:auto:sort(value(sum,descending)))" EOT From 3663894523a7f87bcc9864e7defbaba544b9c78b Mon Sep 17 00:00:00 2001 From: "SLW\\ARNAUA" Date: Thu, 24 Mar 2022 12:22:00 +0100 Subject: [PATCH 04/13] adjusted TP_Mobile_PersonalFavorites EMEA PROD --- EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf | 26 ++++++++++++++------ 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf index 482e93f..8425a90 100644 --- a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf +++ b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf @@ -18,13 +18,25 @@ module TP_Mobile_PersonalFavorites { or( in( "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"btc-destination-composite-service - PROD~") - ) - ") - ) -))):splitBy():auto:auto:sort(value(sum,descending)))" + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"btc-destination-composite-service~") + ) + ,entityName.in( + ~"POST /api/v2/favorites~", + ~"POST /api/v3/favorites~", + ~"GET /api/v2/favorites~", + ~"GET /api/v3/favorites~", + ~"GET /api/v1/favorites~", + ~"PUT /api/v2/favorites/~", + ~"PUT /api/v3/favorites/~", + ~"PUT /api/v2/favorites/homework/1~", + ~"PUT /api/v2/favorites/homework/2~" + )") + ) +))):splitBy():sum:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" From 9306aba53a0fb8a451db61da578f3418976cae02 Mon Sep 17 00:00:00 2001 From: "SLW\\ARNAUA" Date: Thu, 24 Mar 2022 14:08:21 +0100 Subject: [PATCH 05/13] adjusted TP_Mobile_Remote360 EMEA PROD --- EMEA_PROD/slo/TP_Mobile_Remote360.tf | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Remote360.tf b/EMEA_PROD/slo/TP_Mobile_Remote360.tf index 111c7f1..02cecf6 100644 --- a/EMEA_PROD/slo/TP_Mobile_Remote360.tf +++ b/EMEA_PROD/slo/TP_Mobile_Remote360.tf @@ -18,13 +18,24 @@ module TP_Mobile_Remote360 { or( in( "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"remote-360-composite-service - PROD~") - ) - ") - ) -))):splitBy():auto:auto:sort(value(sum,descending)))" + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"remote-360-composite-service~") + ) + ,entityName.in( + ~"GET /eadrax-r360/v1/events/$eventId~", + ~"POST /eadrax-r360/v1/events/$eventId/cancel~", + ~"POST /eadrax-r360/v1/event/execute~", + ~"GET /eadrax-r360/v1/download/$eventId/$fileName~", + ~"POST /eadrax-r360/v1/download/$eventId/$fileName/confirm~", + ~"GET /eadrax-r360/v1/vehicle/$vin/egomodelurl~", + ~"GET /eadrax-r360/v1/vehicle/$vin/key~", + ~"GET /recordings/vehicle/$vin~" + )") + ) +))):splitBy():sum:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" From 9707a2b73209ea2244d6841a7d419eeae0792e27 Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Thu, 24 Mar 2022 14:13:23 +0100 Subject: [PATCH 06/13] adjusted TP_Mobile_Mapping EMEA PROD --- EMEA_PROD/slo/TP_Mobile_Mapping.tf | 31 ++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Mapping.tf b/EMEA_PROD/slo/TP_Mobile_Mapping.tf index 8dbb4eb..fd1c86a 100644 --- a/EMEA_PROD/slo/TP_Mobile_Mapping.tf +++ b/EMEA_PROD/slo/TP_Mobile_Mapping.tf @@ -14,16 +14,27 @@ module TP_Mobile_Mapping { metric_expression = <<-EOT (100)- (builtin:service.keyRequest.errors.server.rate:filter( - and( - or( - in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"vehicle-mapping-composite-service - PROD~") - ) - ") - ) + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-user-composite-service - PROD~", + ~"vehicle-mapping-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v2/presentation/users/validate~", + ~"POST /api/v2/vehicles//primary~", + ~"POST /api/v2/vehicles//primary/map~", + ~"POST /api/v1/vehicles//validate-security-code~", + ~"POST /api/v1/vehicles//resend-security-code~", + ~"DELETE /api/v1/vehicles/~" + )") + ) ))):splitBy():sum:auto:sort(value(sum,descending)))" EOT From 216ae57ad6c087e58321f1f7b93447caada84c79 Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Thu, 24 Mar 2022 14:46:40 +0100 Subject: [PATCH 07/13] adjusted TP_Mobile_VehicleData EMEA PROD --- EMEA_PROD/slo/TP_Mobile_VehicleData.tf | 27 ++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf index 9542f55..351a284 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf @@ -14,16 +14,23 @@ module TP_Mobile_VehicleData { metric_expression = <<-EOT (100)- (builtin:service.keyRequest.errors.server.rate:filter( - and( - or( - in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"VehicleService - PROD~") - ) - ") - ) + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-vehicle-composite-service - PROD~", + ~"VehicleService - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v1/vehicles//state~", + ~"GET /v1/vehicle/~" + )") + ) ))):splitBy():sum:auto:sort(value(sum,descending)))" EOT From e81cc7cc7bafdb1e8f18951e164a8dc87f87c64a Mon Sep 17 00:00:00 2001 From: "SLW\\ARNAUA" Date: Thu, 24 Mar 2022 14:46:45 +0100 Subject: [PATCH 08/13] adjusted TP_Mobile_RemoteServices EMEA PROD --- EMEA_PROD/slo/TP_Mobile_RemoteServices.tf | 27 +++++++++++++++++------ 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf index 6848345..aaadad1 100644 --- a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf +++ b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf @@ -18,13 +18,26 @@ module TP_Mobile_RemoteServices { or( in( "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"btc-vehicle-remote-commands-composite-service - PROD~") - ) - ") - ) -))):splitBy():auto:auto:sort(value(sum,descending)))" + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"btc-vehicle-remote-commands-composite-service~") + ) + ,entityName.in( + ~"POST /api/v2/presentation/remote-commands//door-lock~", + ~"POST /api/v2/presentation/remote-commands//door-unlock~", + ~"POST /api/v2/presentation/remote-commands//climate-now~", + ~"POST /api/v2/presentation/remote-commands//vehicle-finder~", + ~"POST /presentation/remote-commands//climate-timer~", + ~"POST /api/v2/presentation/remote-commands//light-flash~", + ~"POST /api/v2/presentation/remote-commands//charging-profile~", + ~"GET /api/v2/presentation/remote-commands/eventPosition~", + ~"GET /api/v1/presentation/remote-history/~", + ~"GET /api/v2/presentation/remote-commands/eventStatus~" + )") + ) +))):splitBy():sum:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" From 4b735d104ac7b81b800d87c4a8a2a14942d042e0 Mon Sep 17 00:00:00 2001 From: "SLW\\YELGIM" Date: Thu, 24 Mar 2022 14:55:00 +0100 Subject: [PATCH 09/13] fixed splitBy in EMEA PROD --- EMEA_PROD/slo/TP_Mobile_Mapping.tf | 2 +- EMEA_PROD/slo/TP_Mobile_VehicleData.tf | 2 +- EMEA_PROD/slo/TP_Mobile_VehicleList.tf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Mapping.tf b/EMEA_PROD/slo/TP_Mobile_Mapping.tf index fd1c86a..44a67ba 100644 --- a/EMEA_PROD/slo/TP_Mobile_Mapping.tf +++ b/EMEA_PROD/slo/TP_Mobile_Mapping.tf @@ -35,7 +35,7 @@ module TP_Mobile_Mapping { ~"DELETE /api/v1/vehicles/~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf index 351a284..a070262 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf @@ -31,7 +31,7 @@ module TP_Mobile_VehicleData { ~"GET /v1/vehicle/~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf index 6861812..4674716 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf @@ -28,7 +28,7 @@ module TP_Mobile_VehicleList { ~"GET /api/v1/vehicles~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" From 0e5d306a3407e57fc5cff9ec1f3c4e8c381e1a36 Mon Sep 17 00:00:00 2001 From: "SLW\\ARNAUA" Date: Thu, 24 Mar 2022 15:06:03 +0100 Subject: [PATCH 10/13] fixed splitBy in EMEA PROD and adjusted TP_Mobile_Send2VehicleMGU EMEA PROD --- EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf | 2 +- EMEA_PROD/slo/TP_Mobile_Remote360.tf | 2 +- EMEA_PROD/slo/TP_Mobile_RemoteServices.tf | 2 +- EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf | 17 +++++++++++------ 4 files changed, 14 insertions(+), 9 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf index 8425a90..244a2a4 100644 --- a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf +++ b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf @@ -36,7 +36,7 @@ module TP_Mobile_PersonalFavorites { ~"PUT /api/v2/favorites/homework/2~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Remote360.tf b/EMEA_PROD/slo/TP_Mobile_Remote360.tf index 02cecf6..83ad794 100644 --- a/EMEA_PROD/slo/TP_Mobile_Remote360.tf +++ b/EMEA_PROD/slo/TP_Mobile_Remote360.tf @@ -35,7 +35,7 @@ module TP_Mobile_Remote360 { ~"GET /recordings/vehicle/$vin~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf index aaadad1..4a911a6 100644 --- a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf +++ b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf @@ -37,7 +37,7 @@ module TP_Mobile_RemoteServices { ~"GET /api/v2/presentation/remote-commands/eventStatus~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy():auto:auto:sort(value(sum,descending)))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf index 4929b2c..c10cdd5 100644 --- a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf +++ b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf @@ -18,12 +18,17 @@ module TP_Mobile_Send2VehicleMGU { or( in( "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName(~"TripService - PROD~") - ) - ") - ) + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"TripService~") + ) + ,entityName.in( + ~"/v2/motorist/[UUID]/trips", + ~"/v3/motorist/[UUID]/trips" + )") + ) ))):splitBy():auto:auto:sort(value(sum,descending)))" EOT From 0643ae29513ce83fef127dc8df55e3af026c30d7 Mon Sep 17 00:00:00 2001 From: rforstner Date: Mon, 28 Mar 2022 14:52:55 +0200 Subject: [PATCH 11/13] adapted SLOs --- EMEA_PROD/slo/TP_Mobile_DigitalKey.tf | 33 ++++++++++++++--- EMEA_PROD/slo/TP_Mobile_Login.tf | 28 +++++++++++++-- EMEA_PROD/slo/TP_Mobile_Mapping.tf | 30 ++++++++++++++-- EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf | 34 +++++++++++++++--- EMEA_PROD/slo/TP_Mobile_Remote360.tf | 33 ++++++++++++++--- EMEA_PROD/slo/TP_Mobile_RemoteServices.tf | 35 ++++++++++++++++--- EMEA_PROD/slo/TP_Mobile_Send2VehicleLegacy.tf | 30 +++++++++++----- EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf | 25 +++++++++++-- EMEA_PROD/slo/TP_Mobile_VehicleData.tf | 26 ++++++++++++-- EMEA_PROD/slo/TP_Mobile_VehicleList.tf | 23 ++++++++++-- 10 files changed, 256 insertions(+), 41 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf b/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf index e880654..58f2d0d 100644 --- a/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf +++ b/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf @@ -12,8 +12,8 @@ module TP_Mobile_Login { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -22,8 +22,8 @@ module TP_Mobile_Login { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"TrackApi~", - ~"digital-key-composite-service~" + ~"TrackApi - smc - PROD~", + ~"digital-key-composite-service - PROD~" ) ) ,entityName.in( @@ -33,7 +33,30 @@ module TP_Mobile_Login { ~"GET /api/v1/digitalkey//pairing~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"TrackApi - smc - PROD~", + ~"digital-key-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"POST /smc2-bl/track/v2/trackKey~", + ~"POST /smc2-bl/track/v2/manageKey~", + ~"GET /api/v1/digitalkey//password~", + ~"GET /api/v1/digitalkey//pairing~" + )") + ) +))):splitBy())) +" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Login.tf b/EMEA_PROD/slo/TP_Mobile_Login.tf index 6a737a1..f7a9419 100644 --- a/EMEA_PROD/slo/TP_Mobile_Login.tf +++ b/EMEA_PROD/slo/TP_Mobile_Login.tf @@ -12,8 +12,8 @@ module TP_Mobile_Login { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -32,7 +32,29 @@ module TP_Mobile_Login { ~"POST /api/v1/oauth/token/identifier~" )") ) -))):splitBy():sum:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-user-composite-service - PROD~", + ~"btc-connected-oauth-service - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v1/presentation/oauth/config~", + ~"GET /api/v1/presentation/profile-tab~", + ~"POST /api/v1/oauth/token/identifier~" + )") + ) +))):splitBy())) +" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Mapping.tf b/EMEA_PROD/slo/TP_Mobile_Mapping.tf index 44a67ba..df7b039 100644 --- a/EMEA_PROD/slo/TP_Mobile_Mapping.tf +++ b/EMEA_PROD/slo/TP_Mobile_Mapping.tf @@ -12,8 +12,8 @@ module TP_Mobile_Mapping { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -35,7 +35,31 @@ module TP_Mobile_Mapping { ~"DELETE /api/v1/vehicles/~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-user-composite-service - PROD~", + ~"vehicle-mapping-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v2/presentation/users/validate~", + ~"POST /api/v2/vehicles//primary~", + ~"POST /api/v2/vehicles//primary/map~", + ~"POST /api/v1/vehicles//validate-security-code~", + ~"POST /api/v1/vehicles//resend-security-code~", + ~"DELETE /api/v1/vehicles/~" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf index 2be711c..0775c21 100644 --- a/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf +++ b/EMEA_PROD/slo/TP_Mobile_PersonalFavorites.tf @@ -12,8 +12,8 @@ module TP_Mobile_PersonalFavorites { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -22,7 +22,7 @@ module TP_Mobile_PersonalFavorites { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"btc-destination-composite-service~" + ~"btc-destination-composite-service - PROD~" ) ) ,entityName.in( @@ -37,7 +37,33 @@ module TP_Mobile_PersonalFavorites { ~"PUT /api/v2/favorites/homework/2~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-destination-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"POST /api/v2/favorites~", + ~"POST /api/v3/favorites~", + ~"GET /api/v2/favorites~", + ~"GET /api/v3/favorites~", + ~"GET /api/v1/favorites~", + ~"PUT /api/v2/favorites/~", + ~"PUT /api/v3/favorites/~", + ~"PUT /api/v2/favorites/homework/1~", + ~"PUT /api/v2/favorites/homework/2~" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Remote360.tf b/EMEA_PROD/slo/TP_Mobile_Remote360.tf index 7823a09..e8ab5d5 100644 --- a/EMEA_PROD/slo/TP_Mobile_Remote360.tf +++ b/EMEA_PROD/slo/TP_Mobile_Remote360.tf @@ -12,8 +12,8 @@ module TP_Mobile_Remote360 { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -22,7 +22,7 @@ module TP_Mobile_Remote360 { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"remote-360-composite-service~" + ~"remote-360-composite-service - PROD~" ) ) ,entityName.in( @@ -36,7 +36,32 @@ module TP_Mobile_Remote360 { ~"GET /recordings/vehicle/$vin~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"remote-360-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"GET /eadrax-r360/v1/events/$eventId~", + ~"POST /eadrax-r360/v1/events/$eventId/cancel~", + ~"POST /eadrax-r360/v1/event/execute~", + ~"GET /eadrax-r360/v1/download/$eventId/$fileName~", + ~"POST /eadrax-r360/v1/download/$eventId/$fileName/confirm~", + ~"GET /eadrax-r360/v1/vehicle/$vin/egomodelurl~", + ~"GET /eadrax-r360/v1/vehicle/$vin/key~", + ~"GET /recordings/vehicle/$vin~" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf index 7d8a98b..67ee88f 100644 --- a/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf +++ b/EMEA_PROD/slo/TP_Mobile_RemoteServices.tf @@ -12,8 +12,8 @@ module TP_Mobile_RemoteServices { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -22,7 +22,7 @@ module TP_Mobile_RemoteServices { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"btc-vehicle-remote-commands-composite-service~" + ~"btc-vehicle-remote-commands-composite-service - PROD~" ) ) ,entityName.in( @@ -38,7 +38,34 @@ module TP_Mobile_RemoteServices { ~"GET /api/v2/presentation/remote-commands/eventStatus~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-vehicle-remote-commands-composite-service - PROD~" + ) + ) + ,entityName.in( + ~"POST /api/v2/presentation/remote-commands//door-lock~", + ~"POST /api/v2/presentation/remote-commands//door-unlock~", + ~"POST /api/v2/presentation/remote-commands//climate-now~", + ~"POST /api/v2/presentation/remote-commands//vehicle-finder~", + ~"POST /api/v2/presentation/remote-commands//climate-timer~", + ~"POST /api/v2/presentation/remote-commands//light-flash~", + ~"POST /api/v2/presentation/remote-commands//charging-profile~", + ~"GET /api/v2/presentation/remote-commands/eventPosition~", + ~"GET /api/v1/presentation/remote-history/~", + ~"GET /api/v2/presentation/remote-commands/eventStatus~" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Send2VehicleLegacy.tf b/EMEA_PROD/slo/TP_Mobile_Send2VehicleLegacy.tf index 31a73ad..0f92ab2 100644 --- a/EMEA_PROD/slo/TP_Mobile_Send2VehicleLegacy.tf +++ b/EMEA_PROD/slo/TP_Mobile_Send2VehicleLegacy.tf @@ -12,21 +12,33 @@ module TP_Mobile_Send2VehicleLegacy { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( - "dt.entity.service_method", - entitySelector("type(service_method), - fromRelationship.isServiceMethodOfService( - type(~"SERVICE~"),entityName( + "dt.entity.service", + entitySelector("type(service), + entityName( ~"LegacyPoiApi - msgsvc - prod~" ) - ) - ") + ") + ) ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +)):splitBy())/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service", + entitySelector("type(service), + entityName( + ~"LegacyPoiApi - msgsvc - prod~" + ) + ") + ) + ) +)):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf index dbd9bf2..52ae35a 100644 --- a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf +++ b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf @@ -12,8 +12,8 @@ module TP_Mobile_Send2VehicleMGU { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -30,7 +30,26 @@ module TP_Mobile_Send2VehicleMGU { ~"/v3/motorist/[UUID]/trips" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"TripService~" + ) + ) + ,entityName.in( + ~"/v2/motorist/[UUID]/trips", + ~"/v3/motorist/[UUID]/trips" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf index a070262..a5372a1 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleData.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleData.tf @@ -12,8 +12,8 @@ module TP_Mobile_VehicleData { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -31,7 +31,27 @@ module TP_Mobile_VehicleData { ~"GET /v1/vehicle/~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in( + ~"btc-vehicle-composite-service - PROD~", + ~"VehicleService - PROD~" + ) + ) + ,entityName.in( + ~"GET /api/v1/vehicles//state~", + ~"GET /v1/vehicle/~" + )") + ) +))):splitBy())" EOT #if not set (removed) it's defaulted to "-1d" diff --git a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf index 4674716..f2578cd 100644 --- a/EMEA_PROD/slo/TP_Mobile_VehicleList.tf +++ b/EMEA_PROD/slo/TP_Mobile_VehicleList.tf @@ -12,8 +12,8 @@ module TP_Mobile_VehicleList { #metric expression of the calculation as done in data explorer ui metric_expression = <<-EOT -(100)- -(builtin:service.keyRequest.errors.server.rate:filter( +(100)* +((builtin:service.keyRequest.errors.server.successCount:filter( and( or( in( @@ -28,7 +28,24 @@ module TP_Mobile_VehicleList { ~"GET /api/v1/vehicles~" )") ) -))):splitBy():auto:auto:sort(value(sum,descending)))" +))):splitBy()) +/ +(builtin:service.keyRequest.count.server:filter( + and( + or( + in( + "dt.entity.service_method", + entitySelector( + "type(service_method), + fromRelationship.isServiceMethodOfService( + type(~"SERVICE~"),entityName.in + (~"btc-vehicle-composite-service - PROD~") + ) + ,entityName.in( + ~"GET /api/v1/vehicles~" + )") + ) +))):splitBy()))" EOT #if not set (removed) it's defaulted to "-1d" From c94585f28830f6ec8aa746c450a96a1e86a22474 Mon Sep 17 00:00:00 2001 From: rforstner Date: Mon, 28 Mar 2022 14:54:21 +0200 Subject: [PATCH 12/13] adapted SLOs --- EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf index 52ae35a..bf809d3 100644 --- a/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf +++ b/EMEA_PROD/slo/TP_Mobile_Send2VehicleMGU.tf @@ -22,7 +22,7 @@ module TP_Mobile_Send2VehicleMGU { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"TripService~" + ~"TripService - PROD~" ) ) ,entityName.in( @@ -41,7 +41,7 @@ module TP_Mobile_Send2VehicleMGU { "type(service_method), fromRelationship.isServiceMethodOfService( type(~"SERVICE~"),entityName.in( - ~"TripService~" + ~"TripService - PROD~" ) ) ,entityName.in( From b81834091683d952e2d1521baba73fa2ab118d03 Mon Sep 17 00:00:00 2001 From: rforstner Date: Mon, 28 Mar 2022 15:11:20 +0200 Subject: [PATCH 13/13] adapting SLO --- EMEA_PROD/slo/TP_Mobile_DigitalKey.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf b/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf index 58f2d0d..f1166cf 100644 --- a/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf +++ b/EMEA_PROD/slo/TP_Mobile_DigitalKey.tf @@ -1,9 +1,9 @@ -module TP_Mobile_Login { +module TP_Mobile_DigitalKey { source = "../../_dynatrace-base-modules/dynatrace-service-level-objective" - name = "TP_Mobile_Login" + name = "TP_Mobile_DigitalKey" description = "2.0 SLO Mobile"