From 13bb61a73d7bc9c0a5fbc2fdc5130e78f18a7160 Mon Sep 17 00:00:00 2001
From: Antonio Canelas <Antonio.Canelas@ctw.bmwgroup.com>
Date: Mon, 16 Jan 2023 13:25:15 +0000
Subject: [PATCH] OPMAAS-3279 - INFOTAIN-30320: Update ICES FestiveMode
 accordingly recommendations.

---
 CN_PROD/slo/ICES_-_FestiveModeAPI.tf   | 18 +++++++++---------
 EMEA_PROD/slo/ICES_-_FestiveModeAPI.tf |  7 +++----
 2 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/CN_PROD/slo/ICES_-_FestiveModeAPI.tf b/CN_PROD/slo/ICES_-_FestiveModeAPI.tf
index c9dfd3f..c7b1db9 100644
--- a/CN_PROD/slo/ICES_-_FestiveModeAPI.tf
+++ b/CN_PROD/slo/ICES_-_FestiveModeAPI.tf
@@ -7,19 +7,19 @@ module ICES_-_FestiveModeAPI {
 
     description                 = "FestiveModeApi"
 
-    
-    
+
+
     #entity selector object 
-    filter                      = "type(\"SERVICE\"),entityName.in(\"FestiveModeApi\"),tag(\"Environment:PROD\")"
-            
+    filter                      = "type(\"SERVICE\"),entityName.in(\"FestiveModeApi - ices - prod\")"
+
 
     #metric expression of the calculation as done in data explorer ui
-    metric_expression           = "(100)*((1)-(builtin:service.errors.fivexx.rate:splitBy():avg:auto:sort(value(avg,descending)):limit(10))/(builtin:service.requestCount.total:splitBy():sum:auto:sort(value(sum,descending)):limit(10)))" 
- 
+    metric_expression           = "(100)*((1)-(builtin:service.errors.fivexx.count:splitBy():avg:auto:sort(value(avg,descending)):limit(10))/(builtin:service.requestCount.total:splitBy():sum:auto:sort(value(sum,descending)):limit(10)))"
+
+
+    #if not set (removed) it's defaulted to "-1d"
+    timeframe                   = "-1d"
 
-    #if not set (removed) it's defaulted to "-1d" 
-    timeframe                   = "-1d" 
-         
 
     #currently the only possible value
     evaluation                  = "AGGREGATE"           
diff --git a/EMEA_PROD/slo/ICES_-_FestiveModeAPI.tf b/EMEA_PROD/slo/ICES_-_FestiveModeAPI.tf
index c9dfd3f..e277f84 100644
--- a/EMEA_PROD/slo/ICES_-_FestiveModeAPI.tf
+++ b/EMEA_PROD/slo/ICES_-_FestiveModeAPI.tf
@@ -10,12 +10,11 @@ module ICES_-_FestiveModeAPI {
     
     
     #entity selector object 
-    filter                      = "type(\"SERVICE\"),entityName.in(\"FestiveModeApi\"),tag(\"Environment:PROD\")"
-            
+    filter                      = "type(\"SERVICE\"),entityName.in(\"FestiveModeApi - ices - prod\")"
+
 
     #metric expression of the calculation as done in data explorer ui
-    metric_expression           = "(100)*((1)-(builtin:service.errors.fivexx.rate:splitBy():avg:auto:sort(value(avg,descending)):limit(10))/(builtin:service.requestCount.total:splitBy():sum:auto:sort(value(sum,descending)):limit(10)))" 
- 
+    metric_expression           = "(100)*((1)-(builtin:service.errors.fivexx.count:splitBy():avg:auto:sort(value(avg,descending)):limit(10))/(builtin:service.requestCount.total:splitBy():sum:auto:sort(value(sum,descending)):limit(10)))"
 
     #if not set (removed) it's defaulted to "-1d" 
     timeframe                   = "-1d"